Skip to content

Disable some actions in secondary window #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jul 2, 2025

Based on #1624

Limit certain behaviour that would be complicated to synchronize/reconcile with the primary window.

  • Access to terminal
  • Change active project (ChooseProjectButton)
  • Change active project (context menu)
  • Clone repository
  • Checkout/create branch

@danirabbit
Copy link
Member

I don't like this at all :( We should definitely make active project per window for example

@jeremypw
Copy link
Collaborator Author

jeremypw commented Jul 2, 2025

@danirabbit Funnily enough I came to the same conclusion and am implementing that now. It should be possible to allow most actions to be done in either window but I do not want to start saving state per window atm so there may be some restrictions.

I envisage being able to work on two different projects without restrictions but I think we will have to avoid having the same active project in both windows unless git actions are disabled in one of them.

@jeremypw
Copy link
Collaborator Author

jeremypw commented Jul 3, 2025

I think I'll close this and submit a more limited PR implementing per-window active project, based on #1574 as that touches the same code.

Then we can think about any necessary limitations as and when specific issues arise.

@jeremypw jeremypw closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants