ChooseProjectButton: fix shortcut for Open Folder #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
reviewed
Jul 4, 2025
| @@ -75,6 +75,7 @@ public class Code.ChooseProjectButton : Gtk.MenuButton { | |||
| action_name = Scratch.MainWindow.ACTION_PREFIX + Scratch.MainWindow.ACTION_OPEN_FOLDER, | |||
| action_target = new Variant.string (""), | |||
| icon_name = "folder-open-symbolic", | |||
| accel_string = Scratch.MainWindow.ACTION_OPEN_FOLDER_ACCEL | |||
There was a problem hiding this comment.
This seems like a workaround for a bug in accel label. We should probably fix the bug instead
danirabbit
reviewed
Jul 4, 2025
| @@ -41,8 +51,5 @@ public class Code.PopoverMenuItem : Gtk.Button { | |||
| popover.popdown (); | |||
| } | |||
| }); | |||
|
|
|||
| bind_property ("action-name", label, "action-name"); | |||
There was a problem hiding this comment.
Instead of removing this we should probably add an action_target property to accel label
There was a problem hiding this comment.
Probably, but Code is still using the Gtk3 Granite library - is this still being developed?
|
Coverting to draft pending changes to Granite.AccelLabel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues found in unreleased commit 34b0af4
There doesn't seem to be an elegant way for the chooser button to get the required accelerator from the MainWindow actiongroup so it exposed as a const string in MainWindow. If there is a better way please advise.