Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DarkModeToggle: don't set schedule when updating from accountsservice #35

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jun 11, 2024

No description provided.

@danirabbit danirabbit requested a review from a team June 11, 2024 04:35
@danirabbit danirabbit requested a review from ryonakano July 10, 2024 19:46
@ryonakano
Copy link
Member

Hmm, I'm still facing the linked issue with this branch, even after installing it and rebooting…

@danirabbit
Copy link
Member Author

@ryonakano oops sorry you're right. This doesn't fix #8. The issue this fixes instead is:

  1. Open System Settings → Desktop → Appearance and select either Default at night or Dark during the day
  2. Select "Sunset to sunrise" and see that the style changes from light to dark (or dark to light)

Without this branch:
3. Schedule gets reset to "Disabled" after the style changes

With this branch:
4. Schedule remains on "sunset to sunrise"

Copy link

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does fix the schedule reset you explained

@danirabbit danirabbit enabled auto-merge (squash) August 7, 2024 00:14
@danirabbit danirabbit merged commit fb50caf into main Aug 7, 2024
4 checks passed
@danirabbit danirabbit deleted the danirabbit/darkmodetoggle-disconnectactive branch August 7, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants