Skip to content

Fix #573 #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix #573 #574

wants to merge 3 commits into from

Conversation

@bbb23exposed
Copy link

Fixes #573

eliben
eliben reviewed Jun 14, 2025
View reviewed changes
Copy link
Owner

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please add a test in tests/test_c_generator.py

@bbb23exposed
Copy link
Author

Thanks for the PR. Please add a test in tests/test_c_generator.py

Done

@eliben
Copy link
Owner

eliben commented Jun 14, 2025

Thanks for the PR. Please add a test in tests/test_c_generator.py

Done

Please test the changes with python -m unittest discover from the root directory.

Also - ideally, the new test should fail without the fix and succeed with it. Is this the case here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eliben eliben eliben left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generating compound expression returning compound literal incorrectly omits final semicolon

2 participants

@bbb23exposed @eliben