Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning for negative range #129

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Fix warning for negative range #129

merged 1 commit into from
Feb 13, 2025
+1 −1

Conversation

idabmat
Copy link
Contributor

@idabmat idabmat commented Feb 13, 2025

Thank you for this amazing library.

Quick fix for the following warning

warning: Range.new/2 and first..last default to a step of -1 when last < first. Use Range.new(first, last, -1) or first..last//-1, or pass 1 if that was your intention

This happens when rolling back the migrations (dev) or when removing error_tracker (prod)

crbelaus
crbelaus approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@crbelaus crbelaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @idabmat ❤️

@crbelaus crbelaus merged commit 2de5a20 into elixir-error-tracker:main Feb 13, 2025
4 checks passed
@idabmat idabmat deleted the fix-range-warning branch February 13, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crbelaus crbelaus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@idabmat @crbelaus