-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exercises 1-20 #1363
Exercises 1-20 #1363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! I left some comments, but I'm really happy about the direction this guide is taking
I accidentally approved instead of just leaving a general comment haha! This is overall great, but I think we should iterate and converge on the solutions for a bit more before merging |
@polvalente Ok, first pass at edits (thanks for reviewing!). A few thoughts:
|
Co-authored-by: Mateusz Sluszniak <[email protected]>
Co-authored-by: Mateusz Sluszniak <[email protected]>
Hey so I apologize for the churn here. I realize it makes this PR harder to review. After some more discussion on slack, I think I'd like to reformat so solutions are wrapped in a I have these changes locally. If there are no objections, I'd like to push them: |
Go ahead! This PR isn't that large that a refactor like this would make it impossible to review again |
Ok, highlights:
|
Co-authored-by: Jonatan Kłosko <[email protected]>
Co-authored-by: Jonatan Kłosko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, I am (still) on holidays. I have dropped just two minor nits and we can ship it!
Co-authored-by: José Valim <[email protected]>
💚 💙 💜 💛 ❤️ |
Description
As discussed in Slack, this PR adds a translation of the first 20 exercises from the Python notebook 100 Numpy Exercises:
https://www.kaggle.com/code/utsav15/100-numpy-exercises/notebook
Changes
exercises-1-20.livemd
filemix.exs
Notes