Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: removes canceled out dim var from padding calculation #1382

Merged
merged 1 commit into from
Nov 30, 2023
Merged

refactor: removes canceled out dim var from padding calculation #1382

merged 1 commit into from
Nov 30, 2023

Conversation

grzuy
Copy link
Contributor

@grzuy grzuy commented Nov 30, 2023

No description provided.

polvalente
polvalente reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@polvalente polvalente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example on what this fixes/changes? A unit test change on this would be nice.

polvalente
polvalente approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@polvalente polvalente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

Just caught what the actual differnce is :)

@polvalente polvalente merged commit 99b6326 into elixir-nx:main Nov 30, 2023
6 of 8 checks passed
@grzuy grzuy deleted the to-padding-config branch December 1, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polvalente polvalente polvalente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grzuy @polvalente