Skip to content

Audio encoder support #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Audio encoder support #35

wants to merge 4 commits into from

Conversation

gBillal
Copy link
Collaborator

@gBillal gBillal commented Mar 8, 2025

No description provided.

Copy link

codecov bot commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.06%. Comparing base (6e20e12) to head (c47ae5b).

Files with missing lines Patch % Lines
lib/xav/encoder.ex 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   77.57%   77.06%   -0.51%     
==========================================
  Files           7        7              
  Lines         107      109       +2     
==========================================
+ Hits           83       84       +1     
- Misses         24       25       +1     
Files with missing lines Coverage Δ
lib/xav.ex 0.00% <ø> (ø)
lib/xav/encoder.ex 90.90% <87.50%> (-4.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e20e12...c47ae5b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gBillal gBillal requested a review from Copilot April 5, 2025 19:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • lib/xav.ex: Language not supported
  • lib/xav/encoder.ex: Language not supported

@@ -1,3 +1,4 @@
#include "channel_layout.c"
Copy link
Preview

Copilot AI Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including a .c file in a header is typically unintended as it can lead to multiple definition issues; consider including the corresponding header (e.g., channel_layout.h) instead.

Suggested change
#include "channel_layout.c"
#include "channel_layout.h"

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant