Skip to content

fix: add streaming + v2 compat, tsup => bun build #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odilitime wants to merge 11 commits into
base: 1.x
Choose a base branch
from
Open

fix: add streaming + v2 compat, tsup => bun build #21

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
053bc53
fix: resolve merge conflicts, types, and add streaming + v2 compat
odilitime Mar 10, 2026
926bb47
chore: pin @elizaos/core to 1.7.2
odilitime Mar 10, 2026
4e1f62e
chore: standalone publish version + git hooks for workspace vs verified
odilitime Mar 10, 2026
7c26aa5
misc: add type safety
odilitime Mar 11, 2026
7a9bc5b
misc: fix issues in tsup.config (tsup.config.ts)
odilitime Mar 11, 2026
18a0752
misc: Dev script `--watch` flag silently ignored by build (package.json)
odilitime Mar 11, 2026
388f6b2
misc: add tests for build (build.ts)
odilitime Mar 11, 2026
f6a675f
misc: fix issues in build (build.ts)
odilitime Mar 11, 2026
2e3634a
misc: improve code quality
odilitime Mar 11, 2026
db5fdb3
misc: fix issues in index (index.ts)
odilitime Mar 11, 2026
7fd7803
docs: add review dismissal comments
odilitime Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 39 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,42 @@
# Dependencies
node_modules
.turbo

# Build outputs
dist
build
*.tsbuildinfo
.turbo
.turbo-tsconfig.json

# Environment files
.env
.eliza**
.env.local
.env.production
.env.bak

# IDE
.idea
.vscode
.zed
.DS_Store

# Test coverage
coverage
.nyc_output

# Logs
*.log
logs

# Cache
cache
.cache
tokencache

# Temporary files
*.tmp
*.temp
.tmp

# Bundler artifacts
tsup.config.bundled_*.mjs
62 changes: 62 additions & 0 deletions build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
#!/usr/bin/env bun
import { $ } from "bun";

async function build() {
const totalStart = Date.now();
const pkg = await Bun.file("package.json").json();
const externalDeps = [
...Object.keys(pkg.dependencies ?? {}),
...Object.keys(pkg.peerDependencies ?? {}),
];

// Use the clean script from package.json
if (pkg.scripts?.clean) {
console.log("🧹 Cleaning...");
await $`bun run clean`.quiet();
Comment on lines +12 to +16
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build.ts always runs the package's clean script before building. In this repo the clean script removes node_modules, so running build/dev will delete installed dependencies and can break or severely slow builds. Consider limiting clean to build artifacts (e.g., dist/tsbuildinfo) or make cleaning opt-in via a flag.

Suggested change
// Use the clean script from package.json
if (pkg.scripts?.clean) {
console.log("🧹 Cleaning...");
await $`bun run clean`.quiet();
// Use the clean script from package.json (opt-in via --clean)
const shouldClean = process.argv.includes("--clean");
if (pkg.scripts?.clean && shouldClean) {
console.log("🧹 Cleaning...");
await $`bun run clean`.quiet();
} else if (pkg.scripts?.clean && !shouldClean) {
console.log("ℹ️ Skipping clean step (run with --clean to execute `bun run clean`)");

Copilot uses AI. Check for mistakes.
Copy link

@cursor cursor bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build script deletes node_modules before tsc needs them

High Severity

build.ts unconditionally runs bun run clean before building. The clean script includes rm -rf node_modules, which deletes all installed dependencies. The subsequent tsc --project tsconfig.build.json step (line 38) requires node_modules to resolve type declarations for imports like @elizaos/core and ai. This causes tsc to fail or produce broken .d.ts files with unresolved types.

Additional Locations (1)
Fix in Cursor Fix in Web

}

const esmStart = Date.now();
console.log("🔨 Building @elizaos/plugin-ollama...");
const esmResult = await Bun.build({
entrypoints: ["src/index.ts"],
outdir: "dist",
target: "node",
format: "esm",
sourcemap: "external",
minify: false,
external: externalDeps,
});
if (!esmResult.success) {
console.error(esmResult.logs);
throw new Error("ESM build failed");
}
console.log(`✅ Build complete in ${((Date.now() - esmStart) / 1000).toFixed(2)}s`);

const dtsStart = Date.now();
if (true) { // Always generate .d.ts
console.log("📝 Generating TypeScript declarations...");
try {
await $`tsc --project tsconfig.build.json`;
console.log(`✅ Declarations generated in ${((Date.now() - dtsStart) / 1000).toFixed(2)}s`);
} catch (error) {
console.warn(`⚠️ TypeScript declaration generation had errors (${((Date.now() - dtsStart) / 1000).toFixed(2)}s)`);
console.warn(" Build will continue - fix type errors when possible");
}
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The declarations build catches tsc failures and continues. That can produce a JS build with missing/stale/broken .d.ts, which is especially risky for a published package. Consider failing the build on declaration errors (or gating the "continue on error" behavior behind an explicit env var/flag).

Copilot uses AI. Check for mistakes.
} else {
console.log("🔍 Type checking...");
try {
await $`tsc --noEmit --incremental --project tsconfig.build.json`;
console.log(`✅ Type check passed in ${((Date.now() - dtsStart) / 1000).toFixed(2)}s`);
} catch (error) {
console.warn(`⚠️ Type checking had errors (${((Date.now() - dtsStart) / 1000).toFixed(2)}s)`);
console.warn(" Build will continue - fix type errors when possible");
}
}
Copy link

@greptile-apps greptile-apps bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code: hardcoded if (true) makes else branch unreachable

The if (true) guard was likely left as a placeholder during development. The entire else block (type-check-only path) can never execute, which means it is dead code that will mislead anyone reading the file and is never tested.

Suggested change
if (true) { // Always generate .d.ts
console.log("📝 Generating TypeScript declarations...");
try {
await $`tsc --project tsconfig.build.json`;
console.log(`✅ Declarations generated in ${((Date.now() - dtsStart) / 1000).toFixed(2)}s`);
} catch (error) {
console.warn(`⚠️ TypeScript declaration generation had errors (${((Date.now() - dtsStart) / 1000).toFixed(2)}s)`);
console.warn(" Build will continue - fix type errors when possible");
}
} else {
console.log("🔍 Type checking...");
try {
await $`tsc --noEmit --incremental --project tsconfig.build.json`;
console.log(`✅ Type check passed in ${((Date.now() - dtsStart) / 1000).toFixed(2)}s`);
} catch (error) {
console.warn(`⚠️ Type checking had errors (${((Date.now() - dtsStart) / 1000).toFixed(2)}s)`);
console.warn(" Build will continue - fix type errors when possible");
}
}
// Always generate .d.ts
console.log("📝 Generating TypeScript declarations...");
try {
await $`tsc --project tsconfig.build.json`;
console.log(`✅ Declarations generated in ${((Date.now() - dtsStart) / 1000).toFixed(2)}s`);
} catch (error) {
console.warn(`⚠️ TypeScript declaration generation had errors (${((Date.now() - dtsStart) / 1000).toFixed(2)}s)`);
console.warn(" Build will continue - fix type errors when possible");
}


console.log(`🎉 All builds finished in ${((Date.now() - totalStart) / 1000).toFixed(2)}s`);
}

build().catch((err) => {
console.error("Build failed:", err);
process.exit(1);
});
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@
],
"dependencies": {
"@ai-sdk/ui-utils": "^1.2.8",
"@elizaos/core": "^1.0.0",
"@elizaos/core": "1.7.2",
"ai": "^4.3.9",
"js-tiktoken": "^1.0.18",
"ollama-ai-provider": "^1.2.0",
Copy link

@greptile-apps greptile-apps bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsup listed as a runtime dependency

tsup is a build tool and should be in devDependencies, not dependencies. Keeping it in dependencies causes it to be installed in production environments and inflates the package's install footprint for consumers.

Suggested change
"ollama-ai-provider": "^1.2.0",
"tsup": "8.4.0"

Move the line to devDependencies.

"tsup": "8.4.0"
},
"scripts": {
"build": "tsup",
"dev": "tsup --watch",
"build": "bun run build.ts",
"dev": "bun run build.ts --watch",
Copy link

@greptile-apps greptile-apps bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev --watch flag is silently ignored

The new dev script passes --watch to build.ts as a CLI argument, but build.ts never reads process.argv or Bun.argv, so the flag has no effect. Running bun run dev will perform a single build and exit — it will not watch for changes as the script name implies.

Either implement watch mode in build.ts (e.g., via Bun.build({ watch: true, … })) or remove the --watch flag until the feature is ready.

Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dev script passes --watch to build.ts, but build.ts never reads argv or enables Bun.build watch mode / tsc watch. As-is, bun run build.ts --watch will do a one-off build, so dev is misleading/broken. Either implement watch handling in build.ts or change the script to a command that actually watches.

Suggested change
"dev": "bun run build.ts --watch",
"dev": "bun --watch run build.ts",

Copilot uses AI. Check for mistakes.
Copy link

@coderabbitai coderabbitai bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

The dev script's --watch flag is not handled by build.ts.

The dev script passes --watch to build.ts, but build.ts doesn't parse command-line arguments or implement watch mode. The script will run once and exit, not providing the expected continuous rebuild behavior.

Consider either:

  1. Implementing watch mode in build.ts using Bun.argv or a flag parser
  2. Using a different approach for dev mode (e.g., keeping tsup for watch mode)
♻️ Example watch mode implementation 
+const watchMode = Bun.argv.includes("--watch");
+
 async function build() {
   // ... existing build logic ...
 }
 
-build().catch((err) => {
-  console.error("Build failed:", err);
-  process.exit(1);
-});
+if (watchMode) {
+  const { watch } = await import("fs");
+  console.log("👀 Watching for changes...");
+  build(); // Initial build
+  watch("src", { recursive: true }, async (event, filename) => {
+    console.log(`\n📝 ${filename} changed, rebuilding...`);
+    await build();
+  });
+} else {
+  build().catch((err) => {
+    console.error("Build failed:", err);
+    process.exit(1);
+  });
+}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` around lines 33 - 34, The dev script passes --watch to build.ts
but build.ts doesn't read CLI flags, so implement watch handling: update
build.ts to parse Bun.argv (or a flag parser) and add a watch mode that runs the
existing build logic repeatedly or hooks into a file watcher; specifically
detect the presence of "--watch" (or "--watch=true") in Bun.argv inside build.ts
and, when present, start a file watcher loop that re-runs the build routine (the
same function currently performing the single build) on file changes, or
alternatively remove the flag from package.json and use a separate watcher
tool—ensure changes reference build.ts and Bun.argv (or the chosen flag parser)
and reuse the existing build function to avoid duplication.

"lint": "prettier --write ./src",
"clean": "rm -rf dist .turbo node_modules .turbo-tsconfig.json tsconfig.tsbuildinfo",
"format": "prettier --write ./src",
Expand Down
Loading