Skip to content

add new "dialog" element #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpldr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add new "dialog" element #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Html.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ module Html exposing
, small, cite, dfn, abbr, time, var, samp, kbd, s, q
, mark, ruby, rt, rp, bdi, bdo, wbr
, details, summary, menuitem, menu
, dialog
)

{-| This file is organized roughly in order of popularity. The tags which you'd
Expand Down Expand Up @@ -843,3 +844,8 @@ menu : List (Attribute msg) -> List (Html msg) -> Html msg
menu =
Elm.Kernel.VirtualDom.node "menu"


{-| Represents a dialog that can be shown to the user. -}
dialog : List (Attribute msg) -> List (Html msg) -> Html msg
dialog =
Elm.Kernel.VirtualDom.node "dialog"
7 changes: 7 additions & 0 deletions src/Html/Attributes.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ module Html.Attributes exposing
, accesskey, contenteditable, contextmenu, dir, draggable, dropzone
, itemprop, lang, spellcheck, tabindex
, cite, datetime, pubdate, manifest
, open
)

{-| Helper functions for HTML attributes. They are organized roughly by
Expand Down Expand Up @@ -901,6 +902,12 @@ manifest =
Elm.Kernel.VirtualDom.attribute "manifest"


{-| Indicates whether a `dialog` element is visible or not. -}
open : Bool -> Attribute msg
open =
boolProperty "open"


{-- TODO: maybe reintroduce once there's a better way to disambiguate imports
{-| The number of columns a `col` or `colgroup` should span. -}
span : Int -> Attribute msg
Expand Down