fix: add type-gen support for alphanumeric paths #290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Elysia’s fromTypes() type generation fails when a route path contains alphanumeric segments (e.g. /v1, /v2/foo).
For example this snippet.
Root Cause
During type generation, the declaration string is parsed and numeric keys are quoted using this regex:
This works for numeric property keys:
But breaks for alphanumeric property keys:
Fix
Replace the numeric-only key matcher with a more general regex that safely quotes all unquoted valid property keys.
This results in