Open
Conversation
Contributor
WalkthroughThis pull request introduces EdgeOne adapter support for Elysia. It adds a new export in package.json, implements an EdgeOne adapter with context handling and handler creation, and includes comprehensive test coverage for the new adapter integration. Changes
Sequence DiagramsequenceDiagram
actor Client as EdgeOne Platform
participant Handler as createEdgeOneHandler
participant Adapter as EdgeOne Adapter
participant App as Elysia App
Client->>Handler: onRequest(edgeOneContext)
Handler->>Adapter: Validate app compiled
Adapter->>Adapter: Cast context to EdgeOneContext
Adapter->>App: app.fetch(request, context)
App->>App: Route & process request
App-->>Adapter: Response
Adapter-->>Handler: Response
Handler-->>Client: HTTP Response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add EdgeOne Pages adapter for deploying Elysia applications to Tencent Cloud EdgeOne Pages Node Functions.
Features
clientIp,geo,uuid,region) to route handlerscreateEdgeOneHandler()for exporting EdgeOne-compatible handlersUsage
Documentation
https://pages.edgeone.ai/document/node-functions
If this PR is merged, I will create corresponding documentation at https://github.com/elysiajs/documentation.
Testing
Successfully tested on EdgeOne. Screenshots below.
Note: Without a custom domain,
clientIpandgeoare not available. I tested with my own domain, and the IP shown in the screenshot is from a proxy to demonstrate the geo-location feature.Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.