Skip to content

yLabel correction #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qstarx wants to merge 3 commits into
base: master
Choose a base branch
from
Open

yLabel correction #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5116968
Corrected yLabels for area,line and bar chart. Labels and associated …
qstarx Nov 18, 2010
09ad487
last fix produced wrong result if yRange doesnt start from zero. corr…
qstarx Nov 18, 2010
18a747a
posted wrong file
qstarx Nov 22, 2010
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions visualize.jQuery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ $.fn.visualize = function(options, container){
});

//write Y labels
var yScale = canvas.height() / totalYRange;
var yScale = canvas.height() / totalYRange ;
var liBottom = canvas.height() / (yLabels.length-1);
var ylabelsUL = $('<ul class="visualize-labels-y"></ul>')
.width(canvas.width())
Expand All @@ -281,7 +281,7 @@ $.fn.visualize = function(options, container){
$.each(yLabels, function(i){
var thisLi = $('<li><span>'+o.labelFilter(this)+'</span></li>')
.prepend('<span class="line" />')
.css('bottom',liBottom*i)
.css('bottom',(yScale*(yLabels[i]-bottomValue)))
.prependTo(ylabelsUL);
var label = thisLi.find('span:not(.line)');
var topOffset = label.height()/-2;
Expand Down Expand Up @@ -401,15 +401,15 @@ $.fn.visualize = function(options, container){
*/
leftLabels = horizontal ? xLabels : yLabels;
var liBottom = canvas.height() / (leftLabels.length - (horizontal ? 0 : 1));

var yScale = canvas.height() / totalYRange;
var ylabelsUL = $('<ul class="visualize-labels-y"></ul>')
.width(canvas.width())
.height(canvas.height())
.insertBefore(canvas);

$.each(leftLabels, function(i){
var thisLi = $('<li><span>'+o.labelFilter(this)+'</span></li>').prependTo(ylabelsUL);

var label = thisLi.find('span:not(.line)').addClass('label');

if (horizontal) {
Expand Down Expand Up @@ -452,7 +452,7 @@ $.fn.visualize = function(options, container){
}
}
else {
thisLi.css('bottom', liBottom * i).prepend('<span class="line" />');
thisLi.css('bottom', yScale*(yLabels[i]-bottomValue)).prepend('<span class="line" />');
label.css('margin-top', -label.height() / 2)
}
});
Expand Down