[embassy-usb-dfu] support ed25519 verification #4220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the "ci/build" failure is unrelated to this PR but related to some recent changes to |
|
bender run |
|
Sorry about the issues with embassy-mspm0. If you rebase on |
|
@i509VCB thanks! |
This commit adds the ability to verify that USB DFU updates are correctly signed using ed25519. This required adding support to embassy-boot for reading from the DFU partition.
|
Hmmm it seems I just can't get ci/build to pass for this PR. The issue seems unrelated to the code though as it is always all the "rpi-pico teleprobe" tests which are failing and I can't imagine these changes affecting that. Perhaps an issue with the HIL infrastructure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to verify that USB DFU updates are correctly signed using ed25519.
This required adding support to embassy-boot for reading from the DFU partition.
The memory map for the
stm32wb-dfualso had to be adjusted to accommodate the larger bootloader.