Skip to content

prevent skip GC mixin in Minecraft#loadWorld from cancelling all the code at the end of the method #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
embeddedt merged 1 commit into from
Apr 6, 2026
Merged

prevent skip GC mixin in Minecraft#loadWorld from cancelling all the code at the end of the method #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/main/java/org/embeddedt/archaicfix/mixins/client/core/MixinMinecraft.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ public abstract class MixinMinecraft {

@Shadow public abstract void displayGuiScreen(GuiScreen p_147108_1_);

@Shadow public GuiScreen currentScreen;

@Shadow private boolean fullscreen;

/** @reason Makes grass display as fancy regardless of the graphics setting. Matches the appearance of 1.8+ */
Expand All @@ -35,10 +33,8 @@ private boolean getFancyGrass(GameSettings gameSettings) {
return true;
}
/** @reason Removes a call to {@link System#gc()} to make world loading as fast as possible */
@Inject(method = "loadWorld(Lnet/minecraft/client/multiplayer/WorldClient;Ljava/lang/String;)V", at = @At(value = "INVOKE", target = "Ljava/lang/System;gc()V"), cancellable = true)
private void onSystemGC(WorldClient worldClient, String reason, CallbackInfo ci) {
ci.cancel();
}
@Redirect(method = "loadWorld(Lnet/minecraft/client/multiplayer/WorldClient;Ljava/lang/String;)V", at = @At(value = "INVOKE", target = "Ljava/lang/System;gc()V"))
private void onSystemGC() {}

@Inject(method = "checkGLError", at = @At("HEAD"), cancellable = true)
private void skipErrorCheck(String msg, CallbackInfo ci) {
Expand Down
Loading