errors: Recognize HTTP status 0 as AbortError (#243)

This only happens when the browser itself is aborting the request due to e.g. a page reload, which seems impossible to test within our test framework.
ember-cli · Feb 20, 2017 · 174b121 · 174b121
1 parent f624aa4
commit 174b121
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/addon/errors.js b/addon/errors.js
@@ -239,7 +239,11 @@ export function isTimeoutError(error) {
  * @return {Boolean}
  */
 export function isAbortError(error) {
-  return error instanceof AbortError;
+  if (isAjaxError(error)) {
+    return error instanceof AbortError;
+  } else {
+    return error === 0;
+  }
 }
 
 /**

diff --git a/tests/unit/errors-test.js b/tests/unit/errors-test.js
@@ -180,6 +180,10 @@ describe('unit/errors-test - AjaxError', function() {
   });
 
   describe('isAbortError', function() {
+    it('detects error code correctly', function() {
+      ok(isAbortError(0));
+    });
+
     it('detects error class correctly', function() {
       const error = new AbortError();
       ok(isAbortError(error));