Extract rule: template-no-extra-mut-helpers#2432
Extract rule: template-no-extra-mut-helpers#2432NullVoxPopuli wants to merge 1 commit intoember-cli:masterfrom
Conversation
e3c2847 to
fb14ff6
Compare
| @@ -0,0 +1,43 @@ | |||
| # ember/template-no-extra-mut-helpers | |||
There was a problem hiding this comment.
I don't think this ported cleanly from https://github.com/ember-template-lint/ember-template-lint/blob/main/test/unit/rules/no-extra-mut-helper-argument-test.js
|
This looked ok to me, but if Katie thinks there's something wrong, go with what she says :) |
I just cannot find the rule it ported from -- I think it mutated two rules together in a weird way |
|
Claude analysis says: ETL's no-extra-mut-helper-argument — these are ETL's valid cases: PR #2432's rule flags (mut this.value) — exactly the single-arg form ETL considers valid. So three concrete issues:
Bottom line: The rule logic is internally consistent for its stated intent ("unnecessary mut helpers"). But that intent is not sourced from ETL, the docs reference is wrong, and the rule will flag patterns ETL |
|
marking draft, because I need to re-sync the template-lint stuff |
fb14ff6 to
6e0f604
Compare
Split from #2371.