Allow imports ending with .js to resolve properly
#227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See emberjs/ember-cli-babel#519 (comment) This PR would have potentially far-reaching effects. We don't really want to change loader.js at all, it's stable legacy infrastructure that isn't used in the v2 app blueprint. The motivating bug here is in ember-cli-babel, which shouldn't be emitting AMD where the import paths still include file extensions in the first place. But that bug also is probably WONTFIX because it's better to stop using the includeExternalHelpers feature entirely. |
|
Closing per @ef4's comments, the solution described at emberjs/ember-cli-babel#442 (comment) seems to be the better option here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seems to be required for
ember-cli-babelto support@babel/runtimev7.13+.See also emberjs/ember-cli-babel#519