You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't know how to write a version of the code that supports both import { service } from '@ember/service' and import { inject as service } from '@ember/service' at the same time. Maybe one of the maintainers has an answer.
One option would be to only keep the deprecate-import-view-utils-from-ember deprecation fix, which fixes the deprecation message in the browser that can't be silenced by app/deprecation-workflow.js and rely on that for the other two deprecations for now.
I added the import * as serviceModule from '@ember/service' workaround to support older Ember.js versions, as suggested by @SergeAstapov, but now the packaging tests fail with:
Using import * as serviceModule from '@ember/service' is not supported.
I'm not sure what to do about that other than dropping support for older Ember.js versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches the folllowing deprecation warnings: