Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexical this #67

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Lexical this #67

wants to merge 5 commits into from

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jan 8, 2025

This is intended to fix #61.

It has a test failure because related changes are also needed in glimmer and content-tag.

@NullVoxPopuli
Copy link
Contributor

CI was disabled -- I re-enabled it, but it won't run unless you push again

@ef4
Copy link
Contributor Author

ef4 commented Jan 8, 2025

(Actually I think content-tag will not need a change, the eval based scope access should already cover this.)

@wycats
Copy link
Member

wycats commented Jan 9, 2025

(Actually I think content-tag will not need a change, the eval based scope access should already cover this.)

Kind of, but there are some nuances to discuss. Let's discuss it on today's spec call and summarize on this thread afterward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessing this inside a template tag in a test context
3 participants