Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing invalid import #343

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixing invalid import #343

wants to merge 2 commits into from

Conversation

ef4
Copy link

@ef4 ef4 commented Mar 7, 2021

There is no defaultRules export from ./lib/system, so this was a SyntaxError in any system that faithfully follows the module spec.

@ef4
Copy link
Author

ef4 commented Mar 11, 2021

I think the test failure here is because ember-try is using NPM 7, which hard errors on a missing peer dependency. But I don't see why it should be missing. @embroider/hbs-loader has a peerDep on webpack, and those two packages are in fact peers under @embroider/webpack. Maybe something about ember-try is interacting oddly with npm 7.

@ef4 ef4 force-pushed the invalid-import branch from 1187833 to e58feb2 Compare March 11, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant