fix inspector not showing up in certain cases #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
force-pushed
the
fix-chrome-api
branch
2 times, most recently
from
0323608 to
e894550
Compare
patricklx
force-pushed
the
fix-chrome-api
branch
from
e894550 to
08bc7d3
Compare
| @@ -39,8 +43,8 @@ | |||
|
|
|||
| "action": { | |||
| "default_icon": { | |||
| "19": "{{PANE_ROOT}}/assets/images/icon19.png", | |||
| "38": "{{PANE_ROOT}}/assets/images/icon38.png" | |||
| "19": "{{PANE_ROOT}}/assets/images/icon19_grey.png", | |||
There was a problem hiding this comment.
Why are the default icons the grey ones?
There was a problem hiding this comment.
by default it should show not detected icon. as the detection state only shows up when an ember app is detected
| contextMenuListeners.forEach((fn) => fn({ menuItemId: menu.id })); | ||
| }, | ||
|
|
||
| onClicked: { |
There was a problem hiding this comment.
I assume you tested this to ensure it still found the component in the tree and selected it?
There was a problem hiding this comment.
i tested it now :)
works
action icon is always shown there is no option to hide/show anymore instead i switch between grey/orange icon to indicate detection
patricklx
force-pushed
the
fix-chrome-api
branch
from
08bc7d3 to
f6cf5dc
Compare
patricklx
changed the title
RobbieTheWagner
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issues with chrome api.
for some the inspector does not show up, for others it does, not sure why.
fix onclick event & hide/show
action icon is always shown
there is no option to hide/show anymore
instead i switch between grey/orange icon to indicate detection.
enable/disable actually only disables click actions
fixes #2496