Skip to content

Conversation

@pichfl
Copy link
Contributor

@pichfl pichfl commented Aug 4, 2025

Description

  • Adds horizontal scrolling support to ensure deeply nested components remain visible by updating the scroll target positioning to account for item indentation
  • Adds missing accessibility title to the button

Closes #2614

@pichfl pichfl marked this pull request as draft August 5, 2025 12:31
@pichfl pichfl force-pushed the pichfl/scroll-left branch from 8008995 to 45f144d Compare August 6, 2025 13:05
@pichfl pichfl marked this pull request as ready for review August 6, 2025 13:06
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very close, one very very very minor change. Happy to merge without fixing it tbh

@pichfl pichfl force-pushed the pichfl/scroll-left branch from 45f144d to 97062bf Compare August 18, 2025 14:50
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🎉

@pichfl pichfl force-pushed the pichfl/scroll-left branch from 97062bf to 080acfc Compare August 18, 2025 14:55
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the built package and it looks like we introduced a bug 😞 now when you have selected a component, as you hover over other components in the tree it will "jump" you back to the left-right scroll position of the selected component.

I was on a call with @pichfl when I discovered this and he saw the behaviour so I won't provide a video but I can if we need to 👍

@pichfl
Copy link
Contributor Author

pichfl commented Aug 26, 2025

I've updated my code. It does the job, but I'm not convinced of the usefulness of this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scroll components pane horizontally if needed when an element is selected

2 participants