Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Widen test-waiters range #1530

Merged
merged 2 commits into from
Jan 30, 2025
Merged

v4: Widen test-waiters range #1530

merged 2 commits into from
Jan 30, 2025

Conversation

NullVoxPopuli
Copy link
Collaborator

Backport of (#1524)

* Widen test-waiters range

* Add try scenario

* Re-roll lockfile. Don't lie about the test-app's expected node version

* Force re-sync

* What about an override?

* Revert "What about an override?"

This reverts commit f9ca7dd.

* A test needed to be updated

* Add @embroider/macros to the test-app

* Reduce lockfile changes

* Revert "Force re-sync"

This reverts commit 063919b.

* Only the floating test needs the -f
@NullVoxPopuli NullVoxPopuli changed the base branch from master to v4.x January 30, 2025 22:09
@NullVoxPopuli NullVoxPopuli merged commit beb9981 into v4.x Jan 30, 2025
8 of 12 checks passed
@NullVoxPopuli NullVoxPopuli deleted the v4-widen-test-waiters branch January 30, 2025 22:13
@mansona mansona mentioned this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants