Fix assert conditions and incorrect string replacements from import.meta.env?.DEV migration#21120
Merged
NullVoxPopuli merged 2 commits intonvp/no-more-macrosfrom Feb 26, 2026
Merged
Conversation
… incorrect string replacements Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Remove macros in favor of import.meta.env?.DEV
Fix assert conditions and incorrect string replacements from import.meta.env?.DEV migration
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing
babel-plugin-debug-macroschanged howassert()calls with function-typed conditions behave. The plugin previously inlined/transformed such calls; without it,expectAssertion'scheckTesthelper calls any function it receives as a condition — causing the wrong assertion to be captured.Root cause
expectAssertion'scheckTest(test)doestypeof test === 'function' ? test() : test. CallingteardownMandatorySetter()with no args returnsundefined(falsy), so the helper captured this[BUG]assert instead of the expected backtracking assertion — failing the test.Fixes
states.ts/-proxy.ts: Changeassert('[BUG]...', teardownMandatorySetter)andassert('[BUG]...', setupMandatorySetter)to use explicit boolean conditions (!== undefined) socheckTestreceives a plain boolean, not a callable.String literal pollution: Several string literals incorrectly contained
import.meta.env?.DEV(replaced withtrueat build time by the vite plugin):console.debugprefix in@ember/debug/index.ts("import.meta.env?.DEV: ..."→"Ember: ...")resolver.ts,component.ts,expressions.tstracking-test.ts("import.meta.env.DEV mode"→"DEV mode")💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.