Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional log implementation refactor #1806

Merged
merged 1 commit into from
Jan 14, 2025

refactor: alter log service implementation

ea9d7fd
Select commit
Loading
Failed to load commit list.
Merged

Additional log implementation refactor #1806

refactor: alter log service implementation
ea9d7fd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 14, 2025 in 0s

85.44% (-0.02%) compared to c6c297a

View this Pull Request on Codecov

85.44% (-0.02%) compared to c6c297a

Details

Codecov Report

Attention: Patch coverage is 82.35294% with 15 lines in your changes missing coverage. Please review.

Project coverage is 85.44%. Comparing base (c6c297a) to head (ea9d7fd).

Files with missing lines Patch % Lines
...l/api/delegate/ReactNativeInternalInterfaceImpl.kt 0.00% 5 Missing ⚠️
...ernal/api/delegate/EmbraceInternalInterfaceImpl.kt 0.00% 4 Missing ⚠️
.../java/io/embrace/android/embracesdk/EmbraceImpl.kt 86.66% 2 Missing ⚠️
...ernal/api/delegate/FlutterInternalInterfaceImpl.kt 80.00% 0 Missing and 2 partials ⚠️
...mbracesdk/internal/api/delegate/LogsApiDelegate.kt 94.59% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1806      +/-   ##
==========================================
- Coverage   85.45%   85.44%   -0.02%     
==========================================
  Files         473      473              
  Lines       11051    11015      -36     
  Branches     1650     1648       -2     
==========================================
- Hits         9444     9412      -32     
  Misses        870      870              
+ Partials      737      733       -4
Files with missing lines Coverage Δ
...oid/embracesdk/internal/injection/LogModuleImpl.kt 91.42% <100.00%> (-0.24%) ⬇️
...roid/embracesdk/internal/logs/EmbraceLogService.kt 98.07% <100.00%> (+5.53%) ⬆️
...ace/android/embracesdk/internal/logs/LogService.kt 100.00% <100.00%> (ø)
...nternal/api/delegate/UnityInternalInterfaceImpl.kt 44.23% <100.00%> (-3.99%) ⬇️
.../java/io/embrace/android/embracesdk/EmbraceImpl.kt 75.29% <86.66%> (-1.82%) ⬇️
...ernal/api/delegate/FlutterInternalInterfaceImpl.kt 85.71% <80.00%> (-7.15%) ⬇️
...mbracesdk/internal/api/delegate/LogsApiDelegate.kt 85.07% <94.59%> (-0.26%) ⬇️
...ernal/api/delegate/EmbraceInternalInterfaceImpl.kt 78.26% <0.00%> (-6.68%) ⬇️
...l/api/delegate/ReactNativeInternalInterfaceImpl.kt 71.05% <0.00%> (+5.19%) ⬆️

... and 4 files with indirect coverage changes

View more details on Codecov