Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint for attachment #1811

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Add endpoint for attachment #1811

merged 1 commit into from
Jan 13, 2025

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds the attachment endpoint to the enum.

@fractalwrench fractalwrench requested a review from a team as a code owner January 13, 2025 11:52
@fractalwrench fractalwrench changed the base branch from file-attachment to refactor-log-impl-2 January 13, 2025 13:09
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (956c6bd) to head (de1fe3b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1811   +/-   ##
=======================================
  Coverage   85.45%   85.46%           
=======================================
  Files         471      471           
  Lines       11009    11007    -2     
  Branches     1646     1644    -2     
=======================================
- Hits         9408     9407    -1     
  Misses        868      868           
+ Partials      733      732    -1     
Files with missing lines Coverage Δ
...ndroid/embracesdk/internal/comms/api/EmbraceUrl.kt 78.57% <100.00%> (-3.79%) ⬇️
.../android/embracesdk/internal/comms/api/Endpoint.kt 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@fractalwrench fractalwrench changed the base branch from refactor-log-impl-2 to main January 13, 2025 13:59
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@fractalwrench fractalwrench merged commit a2c17ed into main Jan 13, 2025
6 of 7 checks passed
@fractalwrench fractalwrench deleted the add-endpoint branch January 13, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants