Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for UploadSharedObjectFilesTaskTest #2062

Open
wants to merge 1 commit into
base: priettt/hashSharedObjectFilesTaskTest
Choose a base branch
from

Conversation

priettt
Copy link
Contributor

@priettt priettt commented Mar 26, 2025

Goal

Added additional testing for UploadSharedObjectFilesTask.

Some things that will be added in a following PR:

  • Use failBuildOnUploadErrors to decide if we continue the build or we fail it.
  • Address TODOs in the class.

@priettt priettt requested a review from a team as a code owner March 26, 2025 00:13
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priettt priettt force-pushed the priettt/uploadSharedObjectFilesTaskTest branch from 7e16cd0 to 9cf576b Compare March 26, 2025 13:39
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (bf031a8) to head (9cf576b).

Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                           @@
##           priettt/hashSharedObjectFilesTaskTest    #2062   +/-   ##
======================================================================
  Coverage                                  85.37%   85.38%           
======================================================================
  Files                                        466      466           
  Lines                                      10523    10523           
  Branches                                    1558     1558           
======================================================================
+ Hits                                        8984     8985    +1     
+ Misses                                       858      857    -1     
  Partials                                     681      681           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants