Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: golden tests #5

Merged
merged 4 commits into from
Nov 19, 2024
Merged

test: golden tests #5

merged 4 commits into from
Nov 19, 2024

Conversation

JoshuaWell
Copy link
Collaborator

Summary

  • add golden tests
  • add storageAdapter for ImpWidget

Checklist

  • You agree with our CLA
  • Included tests (or is not applicable).
  • Updated documentation (or is not applicable).

@JoshuaWell JoshuaWell requested a review from KochC November 19, 2024 12:31
.flutter-plugins Outdated
shared_preferences_web=/Users/runner/.pub-cache/hosted/pub.dev/shared_preferences_web-2.4.2/
shared_preferences_windows=/Users/runner/.pub-cache/hosted/pub.dev/shared_preferences_windows-2.4.1/
haptic_feedback=/Users/joshuawellbrock/.pub-cache/hosted/pub.dev/haptic_feedback-0.4.2/
path_provider_linux=/Users/joshuawellbrock/.pub-cache/hosted/pub.dev/path_provider_linux-2.2.1/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if you want this to be checked in

Copy link
Collaborator Author

@JoshuaWell JoshuaWell Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are part of .gitignore, they shouldn't be uploaded at all. (.flutter-plugins & .flutter-plugins-dependencies)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this Press Trigger icon correct?

Copy link
Collaborator

@KochC KochC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few questions left

@KochC KochC merged commit aa19b69 into dev Nov 19, 2024
5 checks passed
@KochC KochC deleted the test_tests branch November 19, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants