Skip to content

Fix client hang on receiving a non-EOF error from net.Conn #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: v2
Choose a base branch
from
Open

Fix client hang on receiving a non-EOF error from net.Conn #676

wants to merge 2 commits into from

Conversation

@vzeroupper
Copy link

@vzeroupper vzeroupper commented Mar 17, 2025

This fixes #650.

Had the problem occur a few times.

The limitReader is to return io.ErrUnexpectedEOF instead of io.EOF if connection returns io.EOF in the middle of a literal.

@vzeroupper vzeroupper marked this pull request as ready for review March 17, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v2] fetchCmd.Close() never finish if timeout

1 participant

@vzeroupper