Add clearHistory method to allow manual toast history cleanup - #734
Open
ljhljh127 wants to merge 1 commit into
Open
Add clearHistory method to allow manual toast history cleanup#734ljhljh127 wants to merge 1 commit into
ljhljh127 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ljhljh127
force-pushed
the
feat/add-clear-history
branch
from
February 3, 2026 01:37
2747833 to
ae37b60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dismissed toasts are never removed from ToastState.toasts, causing the array to grow indefinitely. This is especially problematic in long-running SPAs with JSX-heavy toasts, as full React element trees are retained and never garbage collected.
Relates to #729
Solution
Adds toast.clearHistory() method that removes dismissed toasts from the history while preserving active ones.
Why not automatic cleanup?
getHistory() is intentionally designed to return all toasts including dismissed ones. This PR respects that design by providing an opt-in manual cleanup instead of automatic eviction.