fix: Fix wrong height on toast update - #750
Open
patryksliwinski wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
@emilkowalski Would it be possible to apply the same patch to the previous 1.7.4 version, effectively creating a 1.7.5 release? I can submit a pull request for this, but I wanted to check first, is it possible to release a 1.7.5 version? In our company, we're still on 1.7.4 and can't upgrade to 2.0.0 right now due to breaking changes. A fix in 1.7.5 would be really helpful for us. |
patryksliwinski
marked this pull request as draft
March 11, 2026 09:14
patryksliwinski
marked this pull request as ready for review
March 11, 2026 09:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that when toasts with expanded="false" are updated, their height is recalculated incorrectly. This happens because the scale is not cleared before reading the height, resulting in an inaccurate measurement.
It can lead to such behavior after expanding the toasts later
The provided fix may still fail if the height is calculated within the 400ms transition window, but I don't currently see a better solution.