feat: add data-toast-id attribute to toast element - #767
Open
sawirricardo wants to merge 1 commit into
Open
Conversation
Expose the toast ID as a data-toast-id attribute on the rendered <li> element. This enables targeted testing in Playwright/Cypress/RTL, easier DOM querying for automation, and allows child elements inside the toast to retrieve the parent toast ID for dynamic dismissal. Closes emilkowalski#714
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
data-toast-idattribute to the rendered<li>toast element, exposing the toast ID in the DOM.Closes #714
Motivation
data-toast-idand calltoast.dismiss(id)without needing the ID passed through propsExample
Renders:
Changes
data-toast-id={String(toast.id)}to the<li>element inToastcomponentTesting
Added 2 new Playwright tests:
data-toast-idis present on default toasts (auto-incremented numeric IDs)data-toast-idvalue when a custom string ID is provided