fix: recalculate toast height when type or promise state changes - #774
Open
q121212 wants to merge 1 commit into
Open
fix: recalculate toast height when type or promise state changes#774q121212 wants to merge 1 commit into
q121212 wants to merge 1 commit into
Conversation
The height measurement effect was missing toast.type and toast.promise from its dependency array. When a promise toast transitions from loading to success (icon changes from spinner to checkmark) or when a toast is replaced with content of a different height, the layout was not recalculated. Fixes emilkowalski#719
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #719
Problem
When a toast is replaced with another toast of the same ID but different height (e.g. shorter text → longer text, or promise toast loading → success), the layout doesn't recalculate. This causes visual clipping, overlap, or excessive space.
Root Cause
The
useLayoutEffectthat measures and reports toast height was missingtoast.typeandtoast.promisefrom its dependency array. When a promise toast transitions from loading to success, the icon changes from spinner to checkmark (potentially different height), but the effect never re-fires.Fix
Added
toast.typeandtoast.promiseto the dependency array so height measurement runs whenever the toast type or promise state changes.