This repository was archived by the owner on Dec 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 173
preserve CamelCase #130
Open
JesseAldridge
wants to merge
1
commit into
emre:master
Choose a base branch
from
JesseAldridge:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
preserve CamelCase #130
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -170,7 +170,7 @@ def test_advanced_add(self): | |
| with open(self.config_file) as f: | ||
| # check that property is really flushed out to the config? | ||
| content = f.read().encode('ascii') | ||
| self.assertIn(b'identityfile "/tmp/idfilecheck.rsa"', content) | ||
| self.assertIn(b'IdentityFile "/tmp/idfilecheck.rsa"', content) | ||
| self.assertIn(b"stricthostkeychecking yes", content) | ||
| self.assertIn(b"userknownhostsfile /dev/advanced_test", content) | ||
|
|
||
|
|
@@ -184,7 +184,7 @@ def test_add_with_idfile(self): | |
|
|
||
| with open(self.config_file) as f: | ||
| content = f.read().encode('ascii') | ||
| self.assertIn(b'identityfile "/tmp/idfileonlycheck.rsa"', content) | ||
| self.assertIn(b'IdentityFile "/tmp/idfileonlycheck.rsa"', content) | ||
|
|
||
| def test_basic_edit(self): | ||
| out, err, rc = self.run_cmd('edit aws.apache [email protected] {0}'.format(self.config_arg)) | ||
|
|
@@ -215,8 +215,8 @@ def test_update(self): | |
|
|
||
| with open(self.config_file) as f: | ||
| content = f.read().encode('ascii') | ||
| self.assertIn(b"user daghan", content) # see daghan: http://instagram.com/p/lfPMW_qVja | ||
| self.assertIn(b"port 42000", content) | ||
| self.assertIn(b"User daghan", content) # see daghan: http://instagram.com/p/lfPMW_qVja | ||
| self.assertIn(b"Port 42000", content) | ||
|
|
||
| def test_update_regex(self): | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these (StrictHostKeyChecking and UserKnownHostsFile) not also assert CamelCase?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, maybe so. Those look to be coming from
--o "StrictHostKeyChecking=yes"above... which I guess means something like "Add this key val pair".But really the only part of this project I actually care about is this one file:
storm/parsers/ssh_config_parser.py. Maybe I should just break that file out into a separate micro-repo and close this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wonder why dump() isn't respecting the camelcase of the --o option. Need to dig into it further, even though it looks like you've got the lower_to_original function implemented there.