Skip to content

Upgrade to ruff v0.9.1 and add PIE ruff rules. NFC #23362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 10, 2025

Upgrade to ruff v0.9.1 with 2025 stable format. Required no code changes. https://github.com/astral-sh/ruff/releases

Fix #23085 (comment)

Add https://docs.astral.sh/ruff/rules/#flake8-pie-pie

Add ruff rule PLR1714

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

What does PIE stand for in this context?

@sbc100 sbc100 changed the title Upgrade to ruff v0.9.0 and add PIE ruff rules Upgrade to ruff v0.9.0 and add PIE ruff rules. NFC Jan 10, 2025
@cclauss cclauss changed the title Upgrade to ruff v0.9.0 and add PIE ruff rules. NFC Upgrade to ruff v0.9.1 and add PIE ruff rules. NFC Jan 11, 2025
@cclauss
Copy link
Contributor Author

cclauss commented Jan 11, 2025

The flake8-pie description and repo do not mention where the PIE name comes from but merely says that it:
implements misc. lints.

@cclauss cclauss force-pushed the ruff_v0.9.0 branch 3 times, most recently from 8bfec7a to aacd5e6 Compare January 12, 2025 16:23
@hoodmane
Copy link
Collaborator

Of course one thinks of position independent executable but that doesn't really make sense in this context.

@hoodmane hoodmane merged commit 24e4d6e into emscripten-core:main Jan 14, 2025
29 checks passed
@cclauss cclauss deleted the ruff_v0.9.0 branch January 14, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants