Add a way to clear all IndexedDB databases in browser tests #23408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Jan 14, 2025
test/test_browser.py
Outdated
| // Return a code that is easily differentiable from the 0, 1 that | ||
| // the main test returns, which is the # of cached packages. | ||
| emscripten_force_exit(99); | ||
| } |
There was a problem hiding this comment.
What is the actual problem here? I think assert is generally better since it send the line number and filename back. I think it should trigger onAbort which should never be confused with exit:N.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this,
browser.test_preload_cachingworks once, but running it againfinds the cached data and makes it error.
Also clean up the test a little while there.
Unblocks the test for #23059