Bump emscripten's internal node dependency to from v16 to v20 #23409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the minimum version of node need to run the compiler itself and not related to the version needed to run the generated code. This change should probably have been made back when we update emsdk back in October: emscripten-core/emsdk#1476.
|
Actually it looks like 18.19 is still the version found in debian/stable so abandoning this.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the minimum version of node need to run the compiler itself and not related to the version needed to run the generated code.
This change should probably have been made back when we update emsdk back in October: emscripten-core/emsdk#1476.
Up until #23349 this was not actually an issue.
See #23396 and #23407