Remove ATMAINS from JS compiler
#23478
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell the compile-time constant was never documented. Unlike `ATEXITS` and `ATINITS` there was never any corresponding `addAtMain`, and even the `ATMAIN` symbol itself was already not available in `-sSTRICT` or `-sLEGACY_RUNTIME=0` mode. It looks like it was specifically added in order to facilitate the sealing of the filesystem in emscripten-core#8083, but its no longer used for that purpose, and we have no current internal usages.
Collaborator
Author
|
@brendandahl, interestingly enough ATMAINS was originally added specifically to run the I wonder if we should actually not land this PR and instead split up FS.init? |
Collaborator
Author
|
See #8083 |
Collaborator
Author
|
Closing favor of #23488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell the compile-time constant was never documented.
Unlike
ATEXITSandATINITSthere was never any correspondingaddAtMain, and even theATMAINsymbol itself was already not available in-sSTRICTor-sLEGACY_RUNTIME=0mode.It looks like it was specifically added in order to facilitate the sealing of the filesystem in #8083, but its no longer used for that purpose, and we have no current internal usages.