[CI] Enable audio tests in Firefox #23701
Conversation
|
The circleCI runners support "retry with SSH" and you can log into them directly (in case that helps) |
I'll need to create an account and look at it, but it's taking me away from what I'm actually trying to do. I may still quickly try adding the PulseAudio package (which can run in the user account, AFAIK), but I'm going to need to come back to it. |
|
Feel free to de-prioritize this if you other things you are working on. We've be operating without any audio testing in CI for over 10 years now so a little more delay shouldn't be a problem. |
|
Tomorrow I'll make #23659 work with the now working CI, specifically making Then I'm sitting on the code that fixes wasm64 and 2GB for audio. |
|
Testing again locally, adding PulseAudio with its dummy mixer works, then starting it for the user: The CI machine seems to start installing this but fails with gstreamer and its dependencies: |
cwoffenden
force-pushed
the
cw-audio-run-firefox-tests
branch
from
49fe005 to
f3190ee
Compare
|
Woo-hoo! They're running: I'd like to move the install to either its own section or with the Firefox installer, and possibly look at the warnings given (PulseAudio's not meant to be run as root). |
cwoffenden
changed the title
cwoffenden
force-pushed
the
cw-audio-run-firefox-tests
branch
from
d9fa21e to
81c711e
Compare
.circleci/config.yml
Outdated
| # This should add and start PulseAudio's dummy mixer. It will warn | ||
| # that "This program is not intended to be run as root" but it can | ||
| # be ignored. | ||
| apt-get update -y; true |
There was a problem hiding this comment.
Why ; true there? Does apt-get update fail for some reason?
There was a problem hiding this comment.
Yes, it's just in case it fails. The install is the important one, which if that fails then the test will definitely fail, so I was trying to reduce any flakiness.
(And the install failing depends on how old the image is. Install without an update currently fails on CircleCI due to the package URLs being out of date, but doesn't on my Debian VM.)
There was a problem hiding this comment.
I don't think that should be necessary.
Following on from #23665, a dummy audio device is now enabled for Firefox in the CI.
Multiple attempts were tried (adding Alsa's
snd-dummyandsnd-aloop), eventually getting PulseAudio to work.The output from the Firefox runs was manually verified that the tests had run (if they hadn't, due to work being run in the AudioWorklet callback, they'd have timed out and failed).
(Comment edited with the choice of PulseAudio now this works)