Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Existing AudioWorklet futex test moved to browser tests (now audio works) #23719

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

cwoffenden
Copy link
Contributor

Now that the audio tests are running in CI (see #23665) this existing AudioWorklet/futex test can be moved from interactive to browser:

https://github.com/emscripten-core/emscripten/blob/32832575e0d200afcccd1d892ff3555baf54bc83/test/webaudio/audioworklet_emscripten_futex_wake.cpp

It's had the bare minimum to enable it to compile but is otherwise broken and therefore disabled. The issue is here #22962.

A fix is already done with more advanced lock tests, but needs this to land first to get things in the right order.

To confirm the test is broken, comment out the @disabled in line 5518 and run with:

test/runner browser.test_audio_worklet_emscripten_futex_wake

It will fail with:

test.js:1003 Uncaught RuntimeError: Aborted(Assertion failed: emscripten_is_main_browser_thread(), at: /emsdk/emscripten/system/lib/pthread/emscripten_futex_wait.c,26,futex_wait_main_browser_thread)
    at abort (test.js:1003:11)
    at ___assert_fail (test.js:1945:7)
    at test.wasm:0x10a8
    at test.wasm:0xf34
    at test.wasm:0xa78
    at WasmAudioWorkletProcessor.process (test.aw.js:113:34)

@sbc100 This is the last of my planned additions to the audio tests, next are the fixes.

@cwoffenden cwoffenden force-pushed the cw-audio-run-lock-test branch from 6028959 to 8599492 Compare February 21, 2025 17:51
@cwoffenden
Copy link
Contributor Author

The failing test_sse4_2 test is unrelated.

@sbc100 sbc100 merged commit ee520f0 into emscripten-core:main Feb 21, 2025
27 of 29 checks passed
@cwoffenden cwoffenden deleted the cw-audio-run-lock-test branch February 21, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants