Support ES6 module syntax in Acorn, Babel and Closure#23730
Open
kleisauke wants to merge 21 commits intoemscripten-core:mainfrom
Open
Support ES6 module syntax in Acorn, Babel and Closure#23730kleisauke wants to merge 21 commits intoemscripten-core:mainfrom
kleisauke wants to merge 21 commits intoemscripten-core:mainfrom
Conversation
sbc100
reviewed
Feb 23, 2025
kleisauke
force-pushed
the
es6-acorn-closure
branch
from
f53a92d to
c6f028c
Compare
kleisauke
force-pushed
the
es6-acorn-closure
branch
from
c6f028c to
d8831e2
Compare
This file is not included when building with `-sMODULARIZE=instance`.
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (6) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_minimal_esm.json: 2504 => 2427 [-77 bytes / -3.08%] codesize/test_minimal_runtime_code_size_hello_webgl2_wasm.json: 13199 => 13656 [+457 bytes / +3.46%] codesize/test_minimal_runtime_code_size_hello_webgl2_wasm2js.json: 18537 => 19154 [+617 bytes / +3.33%] codesize/test_minimal_runtime_code_size_hello_webgl2_wasm_singlefile.json: 15132 => 15604 [+472 bytes / +3.12%] codesize/test_minimal_runtime_code_size_hello_webgl_wasm.json: 12737 => 13163 [+426 bytes / +3.34%] codesize/test_minimal_runtime_code_size_hello_webgl_wasm2js.json: 18063 => 18652 [+589 bytes / +3.26%] Average change: +2.24% (-3.08% - +3.46%) ```
kleisauke
force-pushed
the
es6-acorn-closure
branch
from
d8831e2 to
254ed04
Compare
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (1) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_minimal_esm.json: 2504 => 2474 [-30 bytes / -1.20%] Average change: -1.20% (-1.20% - -1.20%) ```
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (1) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_minimal_esm.json: 2494 => 2525 [+31 bytes / +1.24%] Average change: +1.24% (+1.24% - +1.24%) ```
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (1) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_minimal_esm.json: 2525 => 2521 [-4 bytes / -0.16%] Average change: -0.16% (-0.16% - -0.16%) ```
kleisauke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acorn, Babel and Closure are now made aware of ES6 module syntax
when linking with
-sEXPORT_ES6. The previous mangling of top-levelawait,
import.meta, and dynamicimport()is tightened to onlymangle top-level await when Closure is enabled, since this is the
only construct not supported there.