Skip to content

Attempt to fix some windows-specific test failures. NFC #24437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Attempt to fix some windows-specific test failures. NFC #24437

wants to merge 1 commit into from

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 29, 2025

Marking these tests as @crossplatform so they will run on windows and macOS during emscripten CI.

Followup to #24435 that disabled these tests under windows.

@sbc100
Attempt to fix some windows-specific test failures. NFC
159569c 
Marking these tests as `@crossplatform` so they will run on windows
and macOS during emscripten CI.

Followup to emscripten-core#24435 that disabled these tests under windows.
@sbc100 sbc100 requested a review from juj May 29, 2025 21:59
@sbc100
Copy link
Collaborator Author

sbc100 commented May 29, 2025

We probably shouldn't land this until we understand why each of these tests is failing on @juj's windows machine.

@juj
Copy link
Collaborator

juj commented May 29, 2025 •
edited
Loading

Looks good.
other.test_emsize is probably a difference between git config (LF vs CRLF convention) between my git installation and upstream CI git installation. Git allows Windows users to choose at installation time to use Windows style \r\n line endings on checked out text files (which is the default, and which I use), or \n line endings.
other.test_abspaths looks like a Python version thing. python/cpython#134904
test_unistd_write_broken_link is probably some filesystem permission/stat convention thing, or a NTFS hard link "must be administrator" thing. I didn't look into that yet.
test_asyncify_lists is the one that I have no idea about.. it is printing errors from somewhere inside the asyncify logic that I couldn't make sense of.

@juj
Copy link
Collaborator

juj commented May 29, 2025

test_unistd_write_broken_link succeeds, but test_unistd_write_broken_link_rawfs fails:

C:\emsdk\emscripten\main>test\runner test_unistd_write_broken_link_rawfs
Running test_core: (1 tests)
test_unistd_write_broken_link_rawfs (test_core.core0.test_unistd_write_broken_link_rawfs) ... -- begin program output --
link result: -1
source_fd: 3, errno: 63 Operation not permitted
target_fd: -1, errno: 44 No such file or directory
Aborted(Assertion failed: r == 3, at: C:\emsdk\emscripten\main\test\unistd\test_unistd_write_broken_link.c,22,main)
C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:617
  var e = new WebAssembly.RuntimeError(what);
          ^

RuntimeError: Aborted(Assertion failed: r == 3, at: C:\emsdk\emscripten\main\test\unistd\test_unistd_write_broken_link.c,22,main)
    at abort (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:617:11)
    at ___assert_fail (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:949:7)
    at wasm://wasm/00010882:wasm-function[7]:0x55f
    at wasm://wasm/00010882:wasm-function[8]:0x73e
    at C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:632:12
    at callMain (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:4739:15)
    at doRun (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:4792:24)
    at run (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:4805:5)
    at removeRunDependency (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:587:7)
    at receiveInstance (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:737:5)
    at receiveInstantiationResult (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:755:12)
    at createWasm (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:781:17)
Thrown at:
    at abort (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:617:11)
    at ___assert_fail (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:949:7)
    at $func7 (wasm://wasm/00010882:1:1376)
    at $main (wasm://wasm/00010882:1:1855)
    at C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:632:12
    at callMain (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:4739:15)
    at doRun (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:4792:24)
    at run (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:4805:5)
    at removeRunDependency (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:587:7)
    at receiveInstance (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:737:5)


Node.js v22.16.0
-- end program output --
FAIL

======================================================================
FAIL: test_unistd_write_broken_link_rawfs (test_core.core0.test_unistd_write_broken_link_rawfs)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\emsdk\emscripten\main\test\common.py", line 915, in resulting_test
    return func(self, *args)
  File "C:\emsdk\emscripten\main\test\common.py", line 501, in metafunc
    func(self, *args, **kwargs)
    ~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\emscripten\main\test\test_core.py", line 6134, in test_unistd_write_broken_link
    self.do_run_in_out_file_test('unistd/test_unistd_write_broken_link.c')
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\emscripten\main\test\common.py", line 1961, in do_run_in_out_file_test
    output = self._build_and_run(srcfile, expected, **kwargs)
  File "C:\emsdk\emscripten\main\test\common.py", line 1995, in _build_and_run
    js_output = self.run_js(js_file, engine, args,
                            assert_returncode=assert_returncode,
                            interleaved_output=interleaved_output)
  File "C:\emsdk\emscripten\main\test\common.py", line 1585, in run_js
    self.fail('JS subprocess failed (%s): %s (expected=%s).  Output:\n%s' % (error.cmd, error.returncode, assert_returncode, ret))
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: JS subprocess failed (C:/emsdk/node/22.16.0_64bit/bin/node.exe --stack-trace-limit=50 --trace-uncaught C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js): 1 (expected=0).  Output:
link result: -1
source_fd: 3, errno: 63 Operation not permitted
target_fd: -1, errno: 44 No such file or directory
Aborted(Assertion failed: r == 3, at: C:\emsdk\emscripten\main\test\unistd\test_unistd_write_broken_link.c,22,main)
C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:617
  var e = new WebAssembly.RuntimeError(what);
          ^

RuntimeError: Aborted(Assertion failed: r == 3, at: C:\emsdk\emscripten\main\test\unistd\test_unistd_write_broken_link.c,22,main)
    at abort (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:617:11)
    at ___assert_fail (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:949:7)
    at wasm://wasm/00010882:wasm-function[7]:0x55f
    at wasm://wasm/00010882:wasm-function[8]:0x73e
    at C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:632:12
    at callMain (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:4739:15)
    at doRun (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:4792:24)
    at run (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:4805:5)
    at removeRunDependency (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:587:7)
    at receiveInstance (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:737:5)
    at receiveInstantiationResult (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:755:12)
    at createWasm (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:781:17)
Thrown at:
    at abort (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:617:11)
    at ___assert_fail (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:949:7)
    at $func7 (wasm://wasm/00010882:1:1376)
    at $main (wasm://wasm/00010882:1:1855)
    at C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:632:12
    at callMain (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:4739:15)
    at doRun (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:4792:24)
    at run (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:4805:5)
    at removeRunDependency (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:587:7)
    at receiveInstance (C:\emsdk\emscripten\main\out\test\test_unistd_write_broken_link.js:737:5)


Node.js v22.16.0


----------------------------------------------------------------------
Ran 1 test in 0.437s

FAILED (failures=1)

C:\emsdk\emscripten\main>

@juj
Copy link
Collaborator

juj commented May 29, 2025

test_asyncifylists failures occur only in core3 suite:

C:\emsdk\emscripten\main>test\runner core3.test_asyncify_lists*
Running test_core: (10 tests)
Using 10 parallel test processes
warning: Asyncify onlylist contained a non-existing function name: __original_main (__original_main)
warning: Asyncify onlylist contained a non-existing function name: c_baz (c_baz)
warning: Asyncify onlylist contained a non-existing function name: __original_main (__original_main)
warning: Asyncify onlylist contained a non-existing function name: c_baz (c_baz)
warning: Asyncify onlylist contained a non-existing function name: c_baz (c_baz)
warning: Asyncify onlylist contained a non-existing function name: __original_main (__original_main)
warning: Asyncify onlylist contained a non-existing function name: c_baz (c_baz)
warning: Asyncify onlylist contained a non-existing function name: __original_main (__original_main)
warning: Asyncify onlylist contained a non-existing function name: c_baz (c_baz)
warning: Asyncify onlylist contained a non-existing function name: __original_main (__original_main)
warning: Asyncify onlylist contained a non-existing function name: c_baz (c_baz)
test_asyncify_lists_onlylist_d (test_core.core3.test_asyncify_lists_onlylist_d) ... FAIL
test_asyncify_lists_onlylist_c (test_core.core3.test_asyncify_lists_onlylist_c) ... FAIL
test_asyncify_lists_onlylist_b (test_core.core3.test_asyncify_lists_onlylist_b) ... FAIL
test_asyncify_lists_removelist_c (test_core.core3.test_asyncify_lists_removelist_c) ... FAIL
test_asyncify_lists_onlylist_b_response (test_core.core3.test_asyncify_lists_onlylist_b_response) ... FAIL
test_asyncify_lists_onlylist_c_response (test_core.core3.test_asyncify_lists_onlylist_c_response) ... FAIL
test_asyncify_lists_onlylist_a (test_core.core3.test_asyncify_lists_onlylist_a) ... FAIL
test_asyncify_lists_removelist_a (test_core.core3.test_asyncify_lists_removelist_a) ... FAIL
test_asyncify_lists_normal (test_core.core3.test_asyncify_lists_normal) ... FAIL
test_asyncify_lists_removelist_b (test_core.core3.test_asyncify_lists_removelist_b) ... FAIL

DONE: combining results on main thread

test_asyncify_lists_normal (test_core.core3.test_asyncify_lists_normal) ... FAIL
test_asyncify_lists_onlylist_a (test_core.core3.test_asyncify_lists_onlylist_a) ... FAIL
test_asyncify_lists_onlylist_b (test_core.core3.test_asyncify_lists_onlylist_b) ... FAIL
test_asyncify_lists_onlylist_b_response (test_core.core3.test_asyncify_lists_onlylist_b_response) ... FAIL
test_asyncify_lists_onlylist_c (test_core.core3.test_asyncify_lists_onlylist_c) ... FAIL
test_asyncify_lists_onlylist_c_response (test_core.core3.test_asyncify_lists_onlylist_c_response) ... FAIL
test_asyncify_lists_onlylist_d (test_core.core3.test_asyncify_lists_onlylist_d) ... FAIL
test_asyncify_lists_removelist_a (test_core.core3.test_asyncify_lists_removelist_a) ... FAIL
test_asyncify_lists_removelist_b (test_core.core3.test_asyncify_lists_removelist_b) ... FAIL
test_asyncify_lists_removelist_c (test_core.core3.test_asyncify_lists_removelist_c) ... FAIL

======================================================================
FAIL: test_asyncify_lists_normal (test_core.core3.test_asyncify_lists_normal)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 58, in testPartExecutor
    yield
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 651, in run
    self._callTestMethod(testMethod)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 606, in _callTestMethod
    if method() is not None:
       ~~~~~~^^
  File "C:\emsdk\emscripten\main\test\common.py", line 915, in resulting_test
    return func(self, *args)
  File "C:\emsdk\emscripten\main\test\test_core.py", line 81, in decorated
    f(self, *args, **kwargs)
    ~^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\emscripten\main\test\test_core.py", line 8297, in test_asyncify_lists
    self.assertFalse(b'main' in binary)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 738, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false

======================================================================
FAIL: test_asyncify_lists_onlylist_a (test_core.core3.test_asyncify_lists_onlylist_a)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 58, in testPartExecutor
    yield
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 651, in run
    self._callTestMethod(testMethod)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 606, in _callTestMethod
    if method() is not None:
       ~~~~~~^^
  File "C:\emsdk\emscripten\main\test\common.py", line 915, in resulting_test
    return func(self, *args)
  File "C:\emsdk\emscripten\main\test\test_core.py", line 81, in decorated
    f(self, *args, **kwargs)
    ~^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\emscripten\main\test\test_core.py", line 8297, in test_asyncify_lists
    self.assertFalse(b'main' in binary)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 738, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false

======================================================================
FAIL: test_asyncify_lists_onlylist_b (test_core.core3.test_asyncify_lists_onlylist_b)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 58, in testPartExecutor
    yield
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 651, in run
    self._callTestMethod(testMethod)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 606, in _callTestMethod
    if method() is not None:
       ~~~~~~^^
  File "C:\emsdk\emscripten\main\test\common.py", line 915, in resulting_test
    return func(self, *args)
  File "C:\emsdk\emscripten\main\test\test_core.py", line 81, in decorated
    f(self, *args, **kwargs)
    ~^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\emscripten\main\test\test_core.py", line 8297, in test_asyncify_lists
    self.assertFalse(b'main' in binary)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 738, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false

======================================================================
FAIL: test_asyncify_lists_onlylist_b_response (test_core.core3.test_asyncify_lists_onlylist_b_response)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 58, in testPartExecutor
    yield
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 651, in run
    self._callTestMethod(testMethod)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 606, in _callTestMethod
    if method() is not None:
       ~~~~~~^^
  File "C:\emsdk\emscripten\main\test\common.py", line 915, in resulting_test
    return func(self, *args)
  File "C:\emsdk\emscripten\main\test\test_core.py", line 81, in decorated
    f(self, *args, **kwargs)
    ~^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\emscripten\main\test\test_core.py", line 8297, in test_asyncify_lists
    self.assertFalse(b'main' in binary)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 738, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false

======================================================================
FAIL: test_asyncify_lists_onlylist_c (test_core.core3.test_asyncify_lists_onlylist_c)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 58, in testPartExecutor
    yield
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 651, in run
    self._callTestMethod(testMethod)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 606, in _callTestMethod
    if method() is not None:
       ~~~~~~^^
  File "C:\emsdk\emscripten\main\test\common.py", line 915, in resulting_test
    return func(self, *args)
  File "C:\emsdk\emscripten\main\test\test_core.py", line 81, in decorated
    f(self, *args, **kwargs)
    ~^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\emscripten\main\test\test_core.py", line 8297, in test_asyncify_lists
    self.assertFalse(b'main' in binary)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 738, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false

======================================================================
FAIL: test_asyncify_lists_onlylist_c_response (test_core.core3.test_asyncify_lists_onlylist_c_response)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 58, in testPartExecutor
    yield
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 651, in run
    self._callTestMethod(testMethod)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 606, in _callTestMethod
    if method() is not None:
       ~~~~~~^^
  File "C:\emsdk\emscripten\main\test\common.py", line 915, in resulting_test
    return func(self, *args)
  File "C:\emsdk\emscripten\main\test\test_core.py", line 81, in decorated
    f(self, *args, **kwargs)
    ~^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\emscripten\main\test\test_core.py", line 8297, in test_asyncify_lists
    self.assertFalse(b'main' in binary)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 738, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false

======================================================================
FAIL: test_asyncify_lists_onlylist_d (test_core.core3.test_asyncify_lists_onlylist_d)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 58, in testPartExecutor
    yield
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 651, in run
    self._callTestMethod(testMethod)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 606, in _callTestMethod
    if method() is not None:
       ~~~~~~^^
  File "C:\emsdk\emscripten\main\test\common.py", line 915, in resulting_test
    return func(self, *args)
  File "C:\emsdk\emscripten\main\test\test_core.py", line 81, in decorated
    f(self, *args, **kwargs)
    ~^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\emscripten\main\test\test_core.py", line 8297, in test_asyncify_lists
    self.assertFalse(b'main' in binary)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 738, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false

======================================================================
FAIL: test_asyncify_lists_removelist_a (test_core.core3.test_asyncify_lists_removelist_a)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 58, in testPartExecutor
    yield
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 651, in run
    self._callTestMethod(testMethod)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 606, in _callTestMethod
    if method() is not None:
       ~~~~~~^^
  File "C:\emsdk\emscripten\main\test\common.py", line 915, in resulting_test
    return func(self, *args)
  File "C:\emsdk\emscripten\main\test\test_core.py", line 81, in decorated
    f(self, *args, **kwargs)
    ~^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\emscripten\main\test\test_core.py", line 8297, in test_asyncify_lists
    self.assertFalse(b'main' in binary)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 738, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false

======================================================================
FAIL: test_asyncify_lists_removelist_b (test_core.core3.test_asyncify_lists_removelist_b)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 58, in testPartExecutor
    yield
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 651, in run
    self._callTestMethod(testMethod)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 606, in _callTestMethod
    if method() is not None:
       ~~~~~~^^
  File "C:\emsdk\emscripten\main\test\common.py", line 915, in resulting_test
    return func(self, *args)
  File "C:\emsdk\emscripten\main\test\test_core.py", line 81, in decorated
    f(self, *args, **kwargs)
    ~^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\emscripten\main\test\test_core.py", line 8297, in test_asyncify_lists
    self.assertFalse(b'main' in binary)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 738, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false

======================================================================
FAIL: test_asyncify_lists_removelist_c (test_core.core3.test_asyncify_lists_removelist_c)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 58, in testPartExecutor
    yield
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 651, in run
    self._callTestMethod(testMethod)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 606, in _callTestMethod
    if method() is not None:
       ~~~~~~^^
  File "C:\emsdk\emscripten\main\test\common.py", line 915, in resulting_test
    return func(self, *args)
  File "C:\emsdk\emscripten\main\test\test_core.py", line 81, in decorated
    f(self, *args, **kwargs)
    ~^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\emscripten\main\test\test_core.py", line 8297, in test_asyncify_lists
    self.assertFalse(b'main' in binary)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "C:\emsdk\python\3.13.3_64bit\Lib\unittest\case.py", line 738, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false

----------------------------------------------------------------------
Ran 10 tests in 1.859s

FAILED (failures=10)
Total core time: 15.716s. Wallclock time: 1.861s. Parallelization: 8.45x.

C:\emsdk\emscripten\main>

sbc100 added a commit to sbc100/emscripten that referenced this pull request May 29, 2025
@sbc100
Fix test_emsize under windows. NFC
1e08a27 
Split out from emscripten-core#24437
@sbc100 sbc100 mentioned this pull request May 29, 2025
Merged
sbc100 added a commit to sbc100/emscripten that referenced this pull request May 29, 2025
@sbc100
Fix other.test_emsize under windows. NFC
60335e4 
Split out from emscripten-core#24437
sbc100 added a commit to sbc100/emscripten that referenced this pull request May 30, 2025
@sbc100
Fix other.test_emsize under windows. NFC
2e0e84f 
Split out from emscripten-core#24437
sbc100 added a commit that referenced this pull request May 30, 2025
@sbc100
Fix test_emsize under windows. NFC (#24439)
fe7b2d3 
Split out from #24437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juj juj Awaiting requested review from juj

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @juj