[wasmfs] Expose wasmfs headers file for out-of-tree filesystems #24744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For versioning we already have |
sbc100
reviewed
Jul 21, 2025
|
|
||
| #pragma once | ||
|
|
||
| #include "file.h" | ||
| #include <emscripten/wasmfs_internal/file.h> |
There was a problem hiding this comment.
Can you leave these as-is, if the files remain in the same directory?
There was a problem hiding this comment.
I will revert for headers..., but it may take until next weekend...
| @@ -15,7 +15,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include "file.h" | |||
| #include <emscripten/wasmfs_internal/file.h> | |||
There was a problem hiding this comment.
I would hope we could keep wasmfs_internal headers in the system/lib/wasmfs directory and then have them installed via the install_system_headers help in tools/system_libs.py. No need to relocate them in git to system/include I would hope.
There was a problem hiding this comment.
Ok, I will check, if this PR is necessary at all.
There was a problem hiding this comment.
Ok, change it as suggested,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves wasmfs header files to the public include file directory, so that it is possible to develop wasmfs file systems, out of tree.
Open points:
There are some prototypical classes of wasmfs, which may be beneficial for certain types of file systems. I did not include them, as I restricted the files to the bare minimum of abstract base classes.
It would be good if out-of-tree filesystems could detect, if the wasmfs headers are in the public include directory and may have some kind of semantic versioning scheme, if the interface changes (e.g., to use the preprocessor). Do you think a global Emscripten macro would help?