Improve the SingleLineTestResult and integrate with parallel_testsuite #25761
Conversation
sbc100
requested review from
juj and
kripken
and removed request for
kripken
|
Replaced #25752 |
|
sbc100
force-pushed
the
SingleLineTestResult_part2
branch
2 times, most recently
from
77cd236 to
c447e52
Compare
sbc100
force-pushed
the
SingleLineTestResult_part2
branch
2 times, most recently
from
a9f51e3 to
8b8c0bc
Compare
test/single_line_runner.py
Outdated
| # Format the line so that it fix within the terminal width, unless it's less then min_len | ||
| def writeStatus(self, test, msg, color, line_pos): | ||
| # Becuse the message can include the skip reason (which can be very long somtimes), truncate it | ||
| # to a reasonable length to avoid exceeding ling length. |
There was a problem hiding this comment.
| # to a reasonable length to avoid exceeding ling length. | |
| # to a reasonable length to avoid exceeding line length. |
|
Looks nice! |
Yes thats is how the parallel test runner works for sure. We don't overwrite the old line until we have new test result. For the |
Now the parallel test suite now longer needs its own reporting logic it can just share use the existing Runner/Result which now supports the color and single long output formats. By default we now buffer test output and use the single line test runner. Adding `-v` will disabled this and give multi-line non-buffered output. Adding another `-v` will enable logging in the test framework (same as setting EMTEST_VERBOSE)
sbc100
force-pushed
the
SingleLineTestResult_part2
branch
from
8b8c0bc to
8e8dabb
Compare
|
I'd be fine not seeing the 'ok', it's more helpful to me to see if a test is taking a long time or hung. |
3 participants
Now the parallel test suite now longer needs its own reporting logic it can just share use the existing Runner/Result which now supports the color and single long output formats.
By default we now buffer test output and use the single line test runner. Adding
-vwill disabled this and give multi-line non-buffered output. Adding another-vwill enable logging in the test framework (same as setting EMTEST_VERBOSE)