Upgrade TypeScript to v7. - #27571
Conversation
sbc100
left a comment
There was a problem hiding this comment.
This doesn't change what we generate, or break compat with v6 right? Its mostly about the version that we test against?
Maybe worth calling that out in the description?
| "@typescript/typescript-openbsd-x64": "7.0.2", | ||
| "@typescript/typescript-sunos-x64": "7.0.2", | ||
| "@typescript/typescript-win32-arm64": "7.0.2", | ||
| "@typescript/typescript-win32-x64": "7.0.2" |
There was a problem hiding this comment.
I guess this is what happens when you try to ship a native binary in node and cover all your bases.. kind of sad. I guess @kripken was right that we should just ship wasm binaries in this case!
|
Emscripten will generate different TS definitions if the user has v6 or v7. We use tsc's |
The behavior of TypeScript's
--emitDeclarationOnlymode has changed in v7 which caused some changes to the definitions that Emscripten outputs now.