Skip to content

Upgrade TypeScript to v7. - #27571

Open
brendandahl wants to merge 1 commit into
emscripten-core:mainfrom
brendandahl:tsc-7
Open

Upgrade TypeScript to v7.#27571
brendandahl wants to merge 1 commit into
emscripten-core:mainfrom
brendandahl:tsc-7

Conversation

@brendandahl

@brendandahl brendandahl commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

The behavior of TypeScript's --emitDeclarationOnly mode has changed in v7 which caused some changes to the definitions that Emscripten outputs now.

@sbc100 sbc100 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't change what we generate, or break compat with v6 right? Its mostly about the version that we test against?

Maybe worth calling that out in the description?

Comment thread package-lock.json
"@typescript/typescript-openbsd-x64": "7.0.2",
"@typescript/typescript-sunos-x64": "7.0.2",
"@typescript/typescript-win32-arm64": "7.0.2",
"@typescript/typescript-win32-x64": "7.0.2"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is what happens when you try to ship a native binary in node and cover all your bases.. kind of sad. I guess @kripken was right that we should just ship wasm binaries in this case!

@brendandahl

Copy link
Copy Markdown
Collaborator Author

Emscripten will generate different TS definitions if the user has v6 or v7. We use tsc's --emitDeclarationOnly which they've change the behavior of. The changes look like they should be fine with either version though, but the user should probably use a consistent version of TS for generating and running their program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants