Skip to content

Remove unused LLDB_ENABLE_LIBEDIT, LLVM_ENABLE_TERMINFO and PYTHON_EXECUTABLE llvm configure options #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcbarton
Copy link

@mcbarton mcbarton commented Feb 3, 2025

If you run

./emsdk install llvm-git-main-64bit

you get the following configure warnings

CMake Warning:
  Manually-specified variables were not used by the project:

    LLDB_ENABLE_LIBEDIT
    LLVM_ENABLE_TERMINFO
    PYTHON_EXECUTABLE

Therefore these options are note being used anymore in the llvm build and can be removed.

@sbc100
Copy link
Collaborator

sbc100 commented Feb 3, 2025

It could be that these are needed when building older versions of LLVM? @juj?

@mcbarton
Copy link
Author

@juj pinging for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants