Ena 5863 updating validation scope #148
Conversation
| ASSEMBLY_CHROMOSOME(Group.ASSEMBLY, Group.PIPELINE), | ||
| /** Pipeline (Webin-CLI transcriptome scope) */ | ||
| ASSEMBLY_TRANSCRIPTOME(Group.ASSEMBLY); | ||
| ASSEMBLY_TRANSCRIPTOME(Group.PIPELINE); |
There was a problem hiding this comment.
I think we should have only four groups (not sure what to call them):
- Group.PIPELINE/WEBIN /** Webin submissions processed by pipelines. */
- Group.EPO /** EPO submissions processed by putff. */
- Group.NCBI /** NCBI submissions processed by putff. */
- GROUP.PUTFF/ENA /** ENA submissions processed by putff. */
We might wish to rename:
- EMBL_TEMPLATE -> TEMPLATE
- ASSEMBLY_TRANSCRIPTOME -> TRANSCRIPTOME
| } | ||
|
|
||
| public enum Group { | ||
| PIPELINE, |
There was a problem hiding this comment.
Suggest to add a few comments ->
/** Webin submissions processed by pipelines. */
PIPELINE
/** Non-Webin submissions processed by putff. */
PUTFF
|
|
||
| @Test | ||
| public void testValidationScopeWithGroup() { | ||
| assertTrue(ValidationScope.NCBI.isInGroup(ValidationScope.Group.NCBI)); |
There was a problem hiding this comment.
Please move the validation scope and group tests into a new class:
ValidationScopeTest
and test that all ValidationScope enums against isInGroup:
@Test
public void testValidationScopeIsInGroup() {
assertTrue(ValidationScope.NCBI.isInGroup(ValidationScope.Group.PUTFF));
assertFalse(ValidationScope.NCBI.isInGroup(ValidationScope.Group.PIPELINE));
etc.
...
}
| assertTrue( | ||
| plan.isInValidationScope( | ||
| new ValidationScope[] {ValidationScope.EMBL, ValidationScope.INSDC})); | ||
| public void testIsInValidationScopePutffGroup() { |
There was a problem hiding this comment.
(Same comment as the previous one) -> Please move the validation scope and group tests into a new class:
ValidationScopeTest
and test that all ValidationScope enums against isInGroup:
@Test
public void testValidationScopeIsInGroup() {
assertTrue(ValidationScope.NCBI.isInGroup(ValidationScope.Group.PUTFF));
assertFalse(ValidationScope.NCBI.isInGroup(ValidationScope.Group.PIPELINE));
etc.
...
}
| assertFalse( | ||
| plan.isInValidationScope( | ||
| new ValidationScope[] {ValidationScope.EPO, ValidationScope.INSDC})); | ||
| public void testIsInValidationScopePipelineGroup() { |
There was a problem hiding this comment.
Replicate what is in the ValidationScope::testValidationScopeIsInGroup() in ValidationPlanTest. The only difference is that ValidationPlanTest creates the ValidationPlan.
| } | ||
|
|
||
| @Test | ||
| public void testIsInValidationScopeNcbiGroup() { |
There was a problem hiding this comment.
Replicate what is in the ValidationScope::testValidationScopeIsInGroup() in ValidationPlanTest. The only difference is that ValidationPlanTest creates the ValidationPlan.
|
No description provided.