speed up matching of filter fields by using a set #9684
Closed
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
rest_framework/filters.py:314
- Switching from a list to a set alters the ordering and potential handling of duplicates. Confirm that downstream code does not rely on the order or duplicate behavior of valid_fields.
valid_fields = {item[0] for item in self.get_valid_fields(queryset, view, {'request': request})}
auvipy
requested changes
Apr 16, 2025
| @@ -311,7 +311,7 @@ def get_valid_fields(self, queryset, view, context={}): | |||
| return valid_fields | |||
|
|
|||
| def remove_invalid_fields(self, queryset, fields, view, request): | |||
| valid_fields = [item[0] for item in self.get_valid_fields(queryset, view, {'request': request})] | |||
| valid_fields = {item[0] for item in self.get_valid_fields(queryset, view, {'request': request})} | |||
There was a problem hiding this comment.
can you add/update tests to verify this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set uses O(1) average lookup time, so we first get all sorting fields (takes O(n)), but then we can do the matching in O(n), whereas now it is worst-case O(n^2).