-
-
Notifications
You must be signed in to change notification settings - Fork 888
Transport API #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport API #963
Conversation
Also rename *Dispatch classes to *Transport and added aliases
Hmmm, not sure what's going on here, all checks are "cancelled" and there's no log at all so I guess I'll try again later 🤷♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fab yup! A few notes. Looking great. 👍
Looks like a linter failure on import sorting... https://github.com/encode/httpx/pull/963/checks?check_run_id=693477366 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I assume the docs would need updating too - we're still using the Dispatch
phrasing there as of the current state of this PR. Do we want to update it in this PR or as a follow-up?
Co-authored-by: Florimond Manca <[email protected]>
Probably best to change the docs now, there's quite a few code snippets using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this whenever you are! Fantastic bit of work and really keen to see this land!
Great, once everyone's happy let's get this in as it is. Couple of follow ups I can think of, which I'll open individual issues for. |
Thanks all! 🎉 |
Closes #768
I did somedispatch > transport
renaming but did not rename the_dispatch
package and the*Dispatch
classes in it. I considered renaming the package to_transports
and all classes to*Transport
with*Dispatch
aliases but thought it might be better to check first.Edit: Pipelines failed for some reason so I went for it while I gave GH actions some time to sort themselves out.